feat(feeds): queue explicit FreshRSS state changes with uncertain-outcome recovery
Build and publish container images / images (push) Failing after 12m40s

This commit is contained in:
Anya Tokugawa committed 2026-11-08 05:51:47 +09:00
1 parent 16e572397b
commit 131a7ca01f
12 files changed
+973 -58

No files matched your search

+5 -2
View File
@@ -42,6 +42,9 @@ func (s *Server) handleFeeds(w http.ResponseWriter, r *http.Request) {
return
}
key := strings.TrimPrefix(r.URL.Path, feedsAPI)
if s.handleFeedAction(w, r, domain, actor, key) {
return
}
if strings.HasPrefix(key, "opml/") {
s.handleFeedOPML(w, r, domain, actor, key)
return
@@ -211,6 +214,6 @@ func (s *Server) handleFeeds(w http.ResponseWriter, r *http.Request) {
func init() {
translations["en"]["feeds.title"] = "RSS"
translations["ja"]["feeds.title"] = "RSS"
translations["en"]["feeds.help"] = "Private local feeds and read-only FreshRSS integration"
translations["ja"]["feeds.help"] = "個人用の簡易RSSとFreshRSS読取連携"
translations["en"]["feeds.help"] = "Private local feeds and FreshRSS integration with optional read/star updates"
translations["ja"]["feeds.help"] = "個人用の簡易RSSとFreshRSS連携(既読・star変更は任意)"
}
+171
View File
@@ -0,0 +1,171 @@
package server
import (
"context"
"errors"
"net/http"
"net/url"
"strings"
"time"
"pageswiki/internal/store"
)
func freshRSSItem(ctx context.Context, client *http.Client, base, auth, id string) (*store.FeedItem, error) {
// FreshRSS uses POST for this read-only item lookup (not GET ?i=...).
raw, _, _, e := feedRequest(ctx, client, "POST", base+"/reader/api/0/stream/items/contents", auth, url.Values{"i": {id}}, nil)
if e != nil {
return nil, e
}
items, e := parseFreshRSSItems(raw, base)
if e != nil {
return nil, e
}
if len(items) != 1 || items[0].ID != id {
return nil, errFeedInvalid
}
return &items[0], nil
}
func feedActionMatches(a store.FeedAction, i *store.FeedItem) bool {
if a.Field == "read" {
return i.Read == a.Desired
}
return i.Starred == a.Desired
}
func (s *Server) runFeedAction(ctx context.Context, client *http.Client, a store.FeedAction, source store.FeedSource) (status, code string, observed *store.FeedItem) {
status = "failed"
if a.Status == "checking" {
status = "unknown"
}
fail := func(e error) (string, string, *store.FeedItem) {
c := e.Error()
switch c {
case "network", "credentials", "remote_error", "limit", "invalid_feed":
default:
c = "invalid_feed"
}
return status, c, nil
}
if !validCalendarSourceURL(source.URL) {
return fail(errFeedInvalid)
}
user, password, e := s.store.OpenFeedCredential(source)
if e != nil {
return fail(errors.New("credentials"))
}
auth, e := freshRSSLogin(ctx, client, source, user, password)
if e != nil {
return fail(e)
}
base := strings.TrimRight(source.URL, "/")
item, e := freshRSSItem(ctx, client, base, auth, a.ID)
if e != nil {
return fail(e)
}
if feedActionMatches(a, item) {
return "confirmed", "", item
}
if a.Status == "checking" {
return "conflict", "conflict", item
}
raw, _, _, e := feedRequest(ctx, client, "GET", base+"/reader/api/0/token", auth, nil, nil)
if e != nil {
return fail(e)
}
token := strings.TrimSpace(string(raw))
if token == "" || len(token) > 4096 || strings.ContainsAny(token, "\r\n") {
return fail(errFeedInvalid)
}
if e = s.store.MarkFeedActionSending(ctx, a, source); e != nil {
return fail(e)
}
// From this point every uncertain result is terminal until an explicit
// read-only recheck. Neither the worker nor a repeated HTTP request resends.
status = "unknown"
field := "r"
if a.Desired {
field = "a"
}
form := url.Values{"i": {a.ID}, "T": {token}, field: {"user/-/state/com.google/" + a.Field}}
raw, _, _, e = feedRequest(ctx, client, "POST", base+"/reader/api/0/edit-tag", auth, form, nil)
if e != nil {
return fail(e)
}
if strings.TrimSpace(string(raw)) != "OK" {
return fail(errFeedInvalid)
}
item, e = freshRSSItem(ctx, client, base, auth, a.ID)
if e != nil {
return fail(e)
}
if !feedActionMatches(a, item) {
return "conflict", "conflict", item
}
return "confirmed", "", item
}
func (s *Server) syncFeedActions(ctx context.Context, client *http.Client) error {
actions, e := s.store.DueFeedActions(ctx)
if e != nil {
return e
}
for _, a := range actions {
if ctx.Err() != nil {
break
}
if deadline, ok := ctx.Deadline(); ok && time.Until(deadline) < 9*time.Second {
break
}
a, source, e := s.store.ClaimFeedAction(ctx, a)
if e != nil {
continue
}
child, cancel := context.WithTimeout(ctx, 8*time.Second)
status, code, item := s.runFeedAction(child, client, a, source)
cancel()
e = s.store.CompleteFeedAction(ctx, a, source, status, code, item)
if e != nil && !errors.Is(e, store.ErrAccessDenied) && !errors.Is(e, store.ErrTaskConflict) {
return e
}
}
return nil
}
func (s *Server) handleFeedAction(w http.ResponseWriter, r *http.Request, domain, actor, key string) bool {
switch {
case key == "action" && r.Method == "GET":
a, e := s.store.FeedAction(r.Context(), domain, actor, r.URL.Query().Get("source"), r.URL.Query().Get("id"))
if e != nil {
taskError(w, e)
return true
}
writeEventJSON(w, 200, map[string]any{"action": a})
return true
case key == "remote-state" && r.Method == "POST":
var input store.FeedAction
if !taskJSON(w, r, &input) {
return true
}
a, e := s.store.QueueFeedAction(r.Context(), domain, actor, input)
if e != nil {
taskError(w, e)
return true
}
writeEventJSON(w, 202, map[string]any{"action": a})
return true
case key == "action/check" && r.Method == "POST":
var input struct {
RequestID string `json:"request_id"`
}
if !taskJSON(w, r, &input) {
return true
}
if e := s.store.RecheckFeedAction(r.Context(), domain, actor, input.RequestID); e != nil {
taskError(w, e)
return true
}
writeEventJSON(w, 202, map[string]bool{"ok": true})
return true
}
return false
}
+404
View File
@@ -0,0 +1,404 @@
package server
import (
"context"
"encoding/json"
"errors"
"io"
"net/http"
"strings"
"testing"
"github.com/google/uuid"
"pageswiki/internal/store"
)
func feedActionFixture(t *testing.T) (*Server, string, string, string, store.FeedSource) {
t.Helper()
s, token, domain, actor, _ := feedFixture(t)
ctx := context.Background()
v := store.FeedSource{UUID: uuid.NewString(), Provider: "freshrss", Title: "Remote", URL: "https://example.org/api/greader.php", Enabled: true, WriteEnabled: true, Interval: 300}
v.Credential, _ = s.store.SealFeedCredential(domain, actor, v.UUID, "reader", "secret")
if _, e := s.store.SaveFeedSource(ctx, domain, actor, v); e != nil {
t.Fatal(e)
}
all, e := s.store.FeedSources(ctx, domain, actor)
if e != nil {
t.Fatal(e)
}
for _, x := range all {
if x.UUID == v.UUID {
v = x
}
}
c, e := s.store.ClaimFeed(ctx, v)
if e != nil {
t.Fatal(e)
}
if e = s.store.CompleteFeed(ctx, c, []store.FeedItem{{ID: "one", Title: "Article", Starred: true}}, "", "", "", false); e != nil {
t.Fatal(e)
}
return s, token, domain, actor, v
}
func newFeedAction(v store.FeedSource) store.FeedAction {
return store.FeedAction{RequestID: uuid.NewString(), Source: v.UUID, ID: "one", Field: "read", Desired: true, SourceVersion: v.Version}
}
type feedRemoteFake struct {
id string
read, star, timeout bool
edits, lookups, requests int
beforeEdit func()
afterEdit func()
}
func (f *feedRemoteFake) client(t *testing.T) *http.Client {
return &http.Client{Transport: feedTransportFunc(func(r *http.Request) (*http.Response, error) {
id := f.id
if id == "" {
id = "one"
}
f.requests++
body := ""
switch {
case strings.HasSuffix(r.URL.Path, "/ClientLogin"):
body = "Auth=test-auth"
case strings.HasSuffix(r.URL.Path, "/stream/items/contents"):
if r.Method != "POST" {
t.Fatal("read lookup requires POST")
}
r.ParseForm()
if r.Form.Get("i") != id {
t.Fatal("wrong item")
}
f.lookups++
cats := []string{}
if f.read {
cats = append(cats, "user/reader/state/com.google/read")
}
if f.star {
cats = append(cats, "user/reader/state/com.google/starred")
}
raw, _ := json.Marshal(map[string]any{"items": []map[string]any{{"id": id, "title": "Article", "categories": cats}}})
body = string(raw)
case strings.HasSuffix(r.URL.Path, "/token"):
body = "write-token"
if f.beforeEdit != nil {
f.beforeEdit()
}
case strings.HasSuffix(r.URL.Path, "/edit-tag"):
if r.Method != "POST" {
t.Fatal("mutation method")
}
r.ParseForm()
if len(r.Form) != 3 || r.Form.Get("T") != "write-token" || r.Form.Get("i") != id {
t.Fatal("unexpected mutation fields", r.Form)
}
if tag := r.Form.Get("a"); tag != "" {
switch tag {
case "user/-/state/com.google/read":
f.read = true
case "user/-/state/com.google/starred":
f.star = true
default:
t.Fatal("wrong tag", tag)
}
} else {
switch r.Form.Get("r") {
case "user/-/state/com.google/read":
f.read = false
case "user/-/state/com.google/starred":
f.star = false
default:
t.Fatal("wrong tag")
}
}
f.edits++
if f.afterEdit != nil {
f.afterEdit()
}
if f.timeout {
return nil, errors.New("synthetic response lost after apply")
}
body = "OK"
default:
t.Fatal("unexpected path", r.URL.Path)
}
return &http.Response{StatusCode: 200, Header: http.Header{}, Body: io.NopCloser(strings.NewReader(body))}, nil
})}
}
func TestFeedActionWritebackReceiptAndIsolation(t *testing.T) {
s, token, domain, actor, v := feedActionFixture(t)
ctx := context.Background()
a := newFeedAction(v)
w := feedRequestTest(s, token, "POST", "remote-state", a)
if w.Code != 202 {
t.Fatal(w.Code, w.Body)
}
if w = feedRequestTest(s, token, "POST", "remote-state", a); w.Code != 202 {
t.Fatal("replay", w.Code, w.Body)
}
changed := a
changed.Desired = false
if w = feedRequestTest(s, token, "POST", "remote-state", changed); w.Code != 412 {
t.Fatal("changed replay", w.Code)
}
changed.RequestID = uuid.NewString()
if w = feedRequestTest(s, token, "POST", "remote-state", changed); w.Code != 412 {
t.Fatal("parallel intent", w.Code)
}
item, _ := s.store.FeedItem(ctx, domain, actor, v.UUID, "one")
if item.Read {
t.Fatal("optimistic cache mutation")
}
f := &feedRemoteFake{star: true}
if e := s.syncFeedActions(ctx, f.client(t)); e != nil {
t.Fatal(e)
}
got, e := s.store.FeedAction(ctx, domain, actor, v.UUID, "one")
if e != nil || got.Status != "confirmed" || f.edits != 1 {
t.Fatal(got, e, f.edits)
}
item, _ = s.store.FeedItem(ctx, domain, actor, v.UUID, "one")
if !item.Read || !item.Starred {
t.Fatal("unrelated star overwritten", item)
}
if w = feedRequestTest(s, token, "POST", "remote-state", a); w.Code != 202 {
t.Fatal("receipt replay", w.Code)
}
if e = s.syncFeedActions(ctx, f.client(t)); e != nil || f.edits != 1 {
t.Fatal("replayed write", e, f.edits)
}
// A second explicit intent already satisfied remotely causes no edit-tag.
a.RequestID = uuid.NewString()
if _, e = s.store.QueueFeedAction(ctx, domain, actor, a); e != nil {
t.Fatal(e)
}
if e = s.syncFeedActions(ctx, f.client(t)); e != nil || f.edits != 1 {
t.Fatal("redundant write", e)
}
other, e := s.store.CreatePasswordAccount(domain, "actionother", "long test password", "Other", "")
if e != nil {
t.Fatal(e)
}
if got, e = s.store.FeedAction(ctx, domain, other.UUID, v.UUID, "one"); e != nil || got != nil {
t.Fatal("other owner receipt", got, e)
}
a.RequestID = uuid.NewString()
if _, e = s.store.QueueFeedAction(ctx, domain, other.UUID, a); e == nil {
t.Fatal("other owner mutation")
}
v.Credential = ""
v.WriteEnabled = false
if _, e = s.store.SaveFeedSource(ctx, domain, actor, v); e != nil {
t.Fatal(e)
}
a.SourceVersion++
if _, e = s.store.QueueFeedAction(ctx, domain, actor, a); e == nil {
t.Fatal("opt-out ignored")
}
}
func TestFeedActionUnknownNeverResendsAndReadOnlyRecheck(t *testing.T) {
s, _, domain, actor, v := feedActionFixture(t)
ctx := context.Background()
a := newFeedAction(v)
if _, e := s.store.QueueFeedAction(ctx, domain, actor, a); e != nil {
t.Fatal(e)
}
f := &feedRemoteFake{star: true, timeout: true}
client := f.client(t)
if e := s.syncFeedActions(ctx, client); e != nil {
t.Fatal(e)
}
got, e := s.store.FeedAction(ctx, domain, actor, v.UUID, "one")
if e != nil || got.Status != "unknown" {
t.Fatal(got, e)
}
item, _ := s.store.FeedItem(ctx, domain, actor, v.UUID, "one")
if item.Read {
t.Fatal("unconfirmed cache")
}
requests := f.requests
if e = s.syncFeedActions(ctx, client); e != nil || f.requests != requests {
t.Fatal("automatic retry", e)
}
if e = s.store.RecheckFeedAction(ctx, domain, actor, a.RequestID); e == nil {
t.Fatal("must wait for claim expiry")
}
// Simulate the uncertainty cooldown without sleeping.
v.Credential = ""
v.WriteEnabled = false
if _, e = s.store.SaveFeedSource(ctx, domain, actor, v); e != nil {
t.Fatal(e)
}
s.store.DB.Exec(`UPDATE feed_actions SET until_ms=0 WHERE request_id=?`, a.RequestID)
if e = s.store.RecheckFeedAction(ctx, domain, actor, a.RequestID); e != nil {
t.Fatal(e)
}
if e = s.syncFeedActions(ctx, client); e != nil {
t.Fatal(e)
}
got, e = s.store.FeedAction(ctx, domain, actor, v.UUID, "one")
if e != nil || got.Status != "confirmed" || f.edits != 1 {
t.Fatal("recheck sent a write", got, e, f.edits)
}
}
func TestFeedActionConflictAndPostSendFence(t *testing.T) {
for _, changed := range []bool{false, true} {
t.Run(map[bool]string{false: "remote_conflict", true: "source_changed"}[changed], func(t *testing.T) {
s, _, domain, actor, v := feedActionFixture(t)
ctx := context.Background()
a := newFeedAction(v)
if _, e := s.store.QueueFeedAction(ctx, domain, actor, a); e != nil {
t.Fatal(e)
}
f := &feedRemoteFake{star: true}
f.afterEdit = func() {
if changed {
v.Credential = ""
v.WriteEnabled = false
if _, e := s.store.SaveFeedSource(ctx, domain, actor, v); e != nil {
t.Fatal(e)
}
} else {
f.read = false
}
}
if e := s.syncFeedActions(ctx, f.client(t)); e != nil {
t.Fatal(e)
}
got, e := s.store.FeedAction(ctx, domain, actor, v.UUID, "one")
want := "conflict"
if changed {
want = "unknown"
}
if e != nil || got.Status != want || f.edits != 1 {
t.Fatal(got, e)
}
item, e := s.store.FeedItem(ctx, domain, actor, v.UUID, "one")
if e != nil || item.Read {
t.Fatal("unconfirmed/fenced value stored", item, e)
}
})
}
}
func TestFeedActionFencesAndRecovery(t *testing.T) {
for _, scenario := range []string{"config", "delete", "readonly", "extension", "crash"} {
t.Run(scenario, func(t *testing.T) {
s, _, domain, actor, v := feedActionFixture(t)
ctx := context.Background()
a := newFeedAction(v)
if _, e := s.store.QueueFeedAction(ctx, domain, actor, a); e != nil {
t.Fatal(e)
}
if scenario == "crash" {
due, e := s.store.DueFeedActions(ctx)
if e != nil || len(due) != 1 {
t.Fatal(e)
}
a, source, e := s.store.ClaimFeedAction(ctx, due[0])
if e != nil {
t.Fatal(e)
}
if _, e = s.store.ClaimFeed(ctx, v); !errors.Is(e, store.ErrTaskConflict) {
t.Fatal("fetch overlapped mutation", e)
}
if e = s.store.MarkFeedActionSending(ctx, a, source); e != nil {
t.Fatal(e)
}
s.store.DB.Exec(`UPDATE feed_actions SET until_ms=0 WHERE request_id=?`, a.RequestID)
due, e = s.store.DueFeedActions(ctx)
if e != nil || len(due) != 0 {
t.Fatal("crash requeued", due, e)
}
got, _ := s.store.FeedAction(ctx, domain, actor, v.UUID, "one")
if got.Status != "unknown" {
t.Fatal(got)
}
return
}
f := &feedRemoteFake{star: true}
f.beforeEdit = func() {
var e error
switch scenario {
case "config":
v.Credential = ""
v.WriteEnabled = false
_, e = s.store.SaveFeedSource(ctx, domain, actor, v)
case "delete":
e = s.store.FeedSourceAction(ctx, domain, actor, v.UUID, "delete", v.Version)
case "readonly":
e = s.store.SetPrincipalState(domain, actor, "readonly")
case "extension":
e = s.setSystemExtensionEnabled(domain, "organizer.feeds", false)
}
if e != nil {
t.Fatal(e)
}
}
if e := s.syncFeedActions(ctx, f.client(t)); e != nil {
t.Fatal(e)
}
if f.edits != 0 {
t.Fatal("sent after revocation")
}
})
}
}
func TestFeedActionSingleFieldAndConcurrentIntent(t *testing.T) {
for _, field := range []string{"read", "starred"} {
for _, desired := range []bool{false, true} {
t.Run(field+map[bool]string{false: "_remove", true: "_add"}[desired], func(t *testing.T) {
s, _, domain, actor, v := feedActionFixture(t)
ctx := context.Background()
a := newFeedAction(v)
a.Field = field
a.Desired = desired
results := make(chan error, 2)
for range 2 {
go func() {
copy := a
copy.RequestID = uuid.NewString()
_, e := s.store.QueueFeedAction(ctx, domain, actor, copy)
results <- e
}()
}
success := 0
for range 2 {
e := <-results
if e == nil {
success++
} else if !errors.Is(e, store.ErrTaskConflict) {
t.Fatal(e)
}
}
if success != 1 {
t.Fatal("concurrent intents accepted", success)
}
f := &feedRemoteFake{read: true, star: true}
if field == "read" {
f.read = !desired
} else {
f.star = !desired
}
if e := s.syncFeedActions(ctx, f.client(t)); e != nil {
t.Fatal(e)
}
if f.edits != 1 {
t.Fatal("wrong edit count", f.edits)
}
if field == "read" {
if f.read != desired || !f.star {
t.Fatal("wrong field changed")
}
} else {
if f.star != desired || !f.read {
t.Fatal("wrong field changed")
}
}
})
}
}
}
+36 -15
View File
@@ -328,11 +328,11 @@ func feedRequest(ctx context.Context, client *http.Client, method, target, auth
}
return raw, res.Header, res.StatusCode, nil
}
func fetchFreshRSS(ctx context.Context, client *http.Client, v store.FeedSource, user, password string, catalogs ...*[]store.FeedRemoteSubscription) ([]store.FeedItem, error) {
func freshRSSLogin(ctx context.Context, client *http.Client, v store.FeedSource, user, password string) (string, error) {
base := strings.TrimRight(v.URL, "/")
raw, _, _, e := feedRequest(ctx, client, "POST", base+"/accounts/ClientLogin", "", url.Values{"Email": {user}, "Passwd": {password}}, nil)
if e != nil {
return nil, e
return "", e
}
auth := ""
for _, line := range strings.Split(string(raw), "\n") {
@@ -341,12 +341,38 @@ func fetchFreshRSS(ctx context.Context, client *http.Client, v store.FeedSource,
}
}
if auth == "" || len(auth) > 4096 || strings.ContainsAny(auth, "\r\n") {
return nil, errors.New("credentials")
return "", errors.New("credentials")
}
raw, _, _, e = feedRequest(ctx, client, "GET", base+"/reader/api/0/stream/contents/reading-list?output=json&n=200", auth, nil, nil)
return auth, nil
}
func fetchFreshRSS(ctx context.Context, client *http.Client, v store.FeedSource, user, password string, catalogs ...*[]store.FeedRemoteSubscription) ([]store.FeedItem, error) {
base := strings.TrimRight(v.URL, "/")
auth, e := freshRSSLogin(ctx, client, v, user, password)
if e != nil {
return nil, e
}
raw, _, _, e := feedRequest(ctx, client, "GET", base+"/reader/api/0/stream/contents/reading-list?output=json&n=200", auth, nil, nil)
if e != nil {
return nil, e
}
items, e := parseFreshRSSItems(raw, base)
if e != nil {
return nil, e
}
if len(catalogs) > 0 {
raw, _, _, e = feedRequest(ctx, client, "GET", base+"/reader/api/0/subscription/list?output=json", auth, nil, nil)
if e != nil {
return nil, e
}
catalog, e := parseFreshRSSCatalog(raw)
if e != nil {
return nil, e
}
*catalogs[0] = catalog
}
return items, nil
}
func parseFreshRSSItems(raw []byte, base string) ([]store.FeedItem, error) {
var response struct {
Items []struct {
ID string `json:"id"`
@@ -411,17 +437,6 @@ func fetchFreshRSS(ctx context.Context, client *http.Client, v store.FeedSource,
}
out = append(out, item)
}
if len(catalogs) > 0 {
raw, _, _, e = feedRequest(ctx, client, "GET", base+"/reader/api/0/subscription/list?output=json", auth, nil, nil)
if e != nil {
return nil, e
}
catalog, e := parseFreshRSSCatalog(raw)
if e != nil {
return nil, e
}
*catalogs[0] = catalog
}
return out, nil
}
@@ -465,6 +480,9 @@ func (s *Server) syncFeedSources(ctx context.Context, job *store.EventJob) error
func (s *Server) syncFeedSourcesWithClient(ctx context.Context, job *store.EventJob, client *http.Client) error {
ctx, cancel := context.WithTimeout(ctx, 35*time.Second)
defer cancel()
if e := s.syncFeedActions(ctx, client); e != nil {
return e
}
sources, e := s.store.DueFeedSources(ctx)
if e != nil {
return e
@@ -474,6 +492,9 @@ func (s *Server) syncFeedSourcesWithClient(ctx context.Context, job *store.Event
if ctx.Err() != nil {
break
}
if deadline, ok := ctx.Deadline(); ok && time.Until(deadline) < 9*time.Second {
break
}
if !s.systemExtensionEnabled(v.Domain, "organizer.feeds") {
continue
}
+21 -1
View File
@@ -543,7 +543,12 @@ func TestFeedsChromium(t *testing.T) {
if e = s.store.CompleteFeed(context.Background(), claim, items, "", "", "", false); e != nil {
t.Fatal(e)
}
fresh, e := s.store.SaveFeedSource(context.Background(), domain, actor, store.FeedSource{UUID: uuid.NewString(), Provider: "freshrss", Title: "FreshRSS fixture", URL: "https://example.org/api/greader.php", Enabled: true, Interval: 300})
fresh := store.FeedSource{UUID: uuid.NewString(), Provider: "freshrss", Title: "FreshRSS fixture", URL: "https://example.org/api/greader.php", Enabled: true, Interval: 300}
fresh.Credential, e = s.store.SealFeedCredential(domain, actor, fresh.UUID, "fixture", "synthetic")
if e != nil {
t.Fatal(e)
}
fresh, e = s.store.SaveFeedSource(context.Background(), domain, actor, fresh)
if e != nil {
t.Fatal(e)
}
@@ -577,6 +582,15 @@ func TestFeedsChromium(t *testing.T) {
web := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
r.Host = "localhost"
r.Header.Set("Authorization", "Bearer "+token)
if r.URL.Path == "/fixture/run-feed-actions" && r.Method == "POST" {
fake := &feedRemoteFake{id: "catalog-b"}
if e := s.syncFeedActions(r.Context(), fake.client(t)); e != nil {
http.Error(w, "test worker failed", 500)
return
}
w.WriteHeader(204)
return
}
if r.URL.Path == "/fixture" {
w.Header().Set("Content-Type", "text/html; charset=utf-8")
fmt.Fprint(w, "<!doctype html><body style='margin:0'><script>"+string(script)+"</script></body>")
@@ -586,6 +600,12 @@ func TestFeedsChromium(t *testing.T) {
}))
defer web.Close()
for _, width := range []string{"1440", "390"} {
if _, e = s.store.DB.Exec(`DELETE FROM feed_actions WHERE source_uuid=?`, fresh.UUID); e != nil {
t.Fatal(e)
}
if _, e = s.store.DB.Exec(`UPDATE feed_items SET is_read=0 WHERE source_uuid=?`, fresh.UUID); e != nil {
t.Fatal(e)
}
ctx, cancel := context.WithTimeout(context.Background(), 45*time.Second)
args := []string{"internal/server/testdata/vim-browser-smoke.mjs", web.URL + "/fixture?width=" + url.QueryEscape(width), t.TempDir(), "/tmp/pageswiki-feeds-" + width + ".png", width, "850"}
out, e := exec.CommandContext(ctx, "node", args...).CombinedOutput()
+8
View File
@@ -33,6 +33,14 @@
d.getElementById('feed-category').value='';d.getElementById('feed-category').dispatchEvent(new w.Event('change'));await wait(()=>d.querySelectorAll('.feed-row').length===2);
d.querySelector('.feed-subscriptions button[data-feed="feed/2"]').click();await wait(()=>d.querySelectorAll('.feed-row').length===1&&d.querySelector('.feed-row').textContent.includes('Catalog second'));
d.querySelector('.feed-row').click();await wait(()=>d.querySelector('#feed-reader .feed-body'));assert(d.querySelectorAll('#feed-reader .feed-actions button:disabled').length===2,'FreshRSS not read-only');
[...d.querySelectorAll('.feed-source')].find(n=>n.textContent.includes('FreshRSS fixture')).querySelector('button:last-child').click();await wait(()=>d.querySelector('#feed-reader form'));
const setting=d.querySelector('#feed-reader form');setting.querySelectorAll('input[type=checkbox]')[1].checked=true;setting.requestSubmit();await wait(()=>!d.querySelector('#feed-reader form')&&d.querySelectorAll('.feed-row').length===1);
d.querySelector('.feed-row').click();await wait(()=>d.querySelector('#feed-reader .feed-body')&&!d.querySelectorAll('#feed-reader .feed-actions button')[1].disabled);
d.querySelectorAll('#feed-reader .feed-actions button')[1].click();await wait(()=>d.querySelector('.feed-action-status')?.textContent==='◷');assert(d.querySelector('.feed-row').classList.contains('unread'),'Queued state shown as confirmed');
const run=await w.fetch('/fixture/run-feed-actions',{method:'POST'});assert(run.status===204,'Background worker failed');await wait(()=>d.querySelector('.feed-action-status')?.textContent==='✓');assert(!d.querySelector('.feed-row').classList.contains('unread'),'Confirmed state not reflected');
// Restore the synthetic source to read-only for the second viewport run.
const api='/_/api/v1/extension/organizer.feeds/',source=(await (await w.fetch(api+'sources')).json()).sources.find(s=>s.title==='FreshRSS fixture');
await w.fetch(api+'sources',{method:'POST',headers:{'Content-Type':'application/json'},body:JSON.stringify({uuid:source.uuid,version:source.version,provider:source.provider,title:source.title,folder:source.folder,url:source.url,interval_seconds:source.interval_seconds,enabled:true,write_enabled:false})});
if(w.innerWidth<=600)d.querySelector('#feed-toolbar button').click();
assert(d.documentElement.scrollWidth<=w.innerWidth,'Catalog overflow');document.body.dataset.vimReady='1';
}catch(e){const out=document.createElement('pre');out.id='error';out.textContent=e.stack;document.body.append(out);}