Add OIDC browser approval and PKCE session handoff for pages CLI
This commit is contained in:
1 parent
2af87b4f58
commit
60f5fb1881
18 files changed
+1397
-23
No files matched your search
@@ -9,6 +9,8 @@ import (
|
||||
"os/exec"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"pageswiki/internal/store"
|
||||
)
|
||||
|
||||
func TestRemoteCLIHTTPIntegration(t *testing.T) {
|
||||
@@ -33,3 +35,48 @@ func TestRemoteCLIHTTPIntegration(t *testing.T) {
|
||||
t.Fatalf("remote CLI: %v\n%s", err, out)
|
||||
}
|
||||
}
|
||||
|
||||
func TestRemoteCLIOIDCIntegration(t *testing.T) {
|
||||
if _, err := exec.LookPath("python3"); err != nil {
|
||||
t.Skip("python3 not installed")
|
||||
}
|
||||
s, api, domain, _ := editorFixture(t)
|
||||
if err := s.store.SetAuthProviderConfig(domain, store.AuthProviderConfig{Kind: "oidc", Enabled: true, Issuer: "https://id.example", ClientID: "client"}); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
s.mux.HandleFunc("/_/auth/", s.handleAuth)
|
||||
s.mux.HandleFunc("/v/raw/", s.handleRawView)
|
||||
s.mux.HandleFunc("/_/api/v1/path-picker", s.handlePathPickerAPI)
|
||||
principal := s.mustCLIPrincipal(t, domain, api)
|
||||
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
r.Host = "localhost"
|
||||
// Test-only bridge in this httptest server. The real signed OIDC callback,
|
||||
// browser binding and CSRF flow are covered by TestCLIAuthOIDCFlow.
|
||||
if r.URL.Path == "/__test/cli-approve" {
|
||||
_ = r.ParseForm()
|
||||
browser, err := s.store.CreateBrowserAuthSession(domain, principal, 0)
|
||||
if err == nil {
|
||||
err = s.store.BindCLIAuth(r.Context(), domain, "http://localhost", r.Form.Get("request"), browser)
|
||||
}
|
||||
if err == nil {
|
||||
err = s.store.DecideCLIAuth(r.Context(), domain, "http://localhost", r.Form.Get("request"), browser, r.Form.Get("code"), "", true)
|
||||
}
|
||||
if err != nil {
|
||||
http.Error(w, "synthetic approval failed", 500)
|
||||
return
|
||||
}
|
||||
writeEventJSON(w, 200, map[string]bool{"approved": true})
|
||||
return
|
||||
}
|
||||
s.withAuthorization(s.mux).ServeHTTP(w, r)
|
||||
}))
|
||||
defer server.Close()
|
||||
ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
|
||||
defer cancel()
|
||||
cmd := exec.CommandContext(ctx, "python3", "pages-cli/test_pages.py", "--oidc-integration")
|
||||
input, _ := json.Marshal(map[string]string{"origin": server.URL})
|
||||
cmd.Stdin = bytes.NewReader(input)
|
||||
if out, err := cmd.CombinedOutput(); err != nil {
|
||||
t.Fatalf("CLI OIDC integration: %v %s", err, out)
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user