feat: atomically capture task mail into Wiki and persist destination defaults
This commit is contained in:
1 parent
52b501d1ce
commit
80d297dab4
14 files changed
+525
-30
No files matched your search
@@ -2,8 +2,10 @@ package server
|
||||
|
||||
import (
|
||||
"crypto/sha256"
|
||||
"database/sql"
|
||||
"encoding/hex"
|
||||
"encoding/json"
|
||||
"errors"
|
||||
"io"
|
||||
"net/http"
|
||||
"strings"
|
||||
@@ -15,7 +17,11 @@ import (
|
||||
)
|
||||
|
||||
func taskJSON(w http.ResponseWriter, r *http.Request, output any) bool {
|
||||
d := json.NewDecoder(http.MaxBytesReader(w, r.Body, 32768))
|
||||
return taskJSONLimit(w, r, output, 32768)
|
||||
}
|
||||
|
||||
func taskJSONLimit(w http.ResponseWriter, r *http.Request, output any, limit int64) bool {
|
||||
d := json.NewDecoder(http.MaxBytesReader(w, r.Body, limit))
|
||||
d.DisallowUnknownFields()
|
||||
if d.Decode(output) != nil || d.Decode(&struct{}{}) != io.EOF {
|
||||
taskError(w, store.ErrTaskInvalid)
|
||||
@@ -61,6 +67,8 @@ type taskCaptureInput struct {
|
||||
ReviewOn *string `json:"review_on"`
|
||||
Estimate *int `json:"estimate_minutes"`
|
||||
Complexity *int `json:"complexity"`
|
||||
WikiBody *string `json:"wiki_body,omitempty"`
|
||||
WikiPrefix *string `json:"wiki_prefix,omitempty"`
|
||||
}
|
||||
|
||||
func (s *Server) handleTaskProductivity(w http.ResponseWriter, r *http.Request, actor string, active bool, kind string) {
|
||||
@@ -181,13 +189,23 @@ func (s *Server) handleTaskProductivity(w http.ResponseWriter, r *http.Request,
|
||||
case "capture":
|
||||
if r.Method == "POST" {
|
||||
var input taskCaptureInput
|
||||
if !taskJSON(w, r, &input) {
|
||||
if !taskJSONLimit(w, r, &input, 2<<20) {
|
||||
return
|
||||
}
|
||||
if id, err := uuid.Parse(input.RequestID); err != nil || id.String() != input.RequestID {
|
||||
taskError(w, store.ErrTaskInvalid)
|
||||
return
|
||||
}
|
||||
raw, _ := json.Marshal(input)
|
||||
hash := sha256.Sum256(raw)
|
||||
requestHash := hex.EncodeToString(hash[:])
|
||||
if old, e := s.store.CapturedTask(r.Context(), domain, actor, input.RequestID, requestHash); e == nil {
|
||||
s.taskResponse(w, r, old, 201)
|
||||
return
|
||||
} else if !errors.Is(e, sql.ErrNoRows) {
|
||||
taskError(w, e)
|
||||
return
|
||||
}
|
||||
p, err := s.store.TaskPreferences(r.Context(), domain, actor)
|
||||
if err != nil {
|
||||
taskError(w, err)
|
||||
@@ -211,9 +229,49 @@ func (s *Server) handleTaskProductivity(w http.ResponseWriter, r *http.Request,
|
||||
item.Complexity = *input.Complexity
|
||||
}
|
||||
applyTaskReminderDefaults(&item, p)
|
||||
raw, _ := json.Marshal(input)
|
||||
hash := sha256.Sum256(raw)
|
||||
item, err = s.store.CaptureTask(r.Context(), domain, actor, input.RequestID, hex.EncodeToString(hash[:]), item)
|
||||
target, body := "", ""
|
||||
if input.WikiBody != nil {
|
||||
prefix := p.WikiPrefix
|
||||
if input.WikiPrefix != nil {
|
||||
prefix = *input.WikiPrefix
|
||||
}
|
||||
if prefix == "" && input.WikiPrefix == nil && item.ProjectUUID != "" {
|
||||
project, e := s.store.GetTask(r.Context(), domain, actor, item.ProjectUUID)
|
||||
if e != nil && !errors.Is(e, sql.ErrNoRows) {
|
||||
taskError(w, e)
|
||||
return
|
||||
}
|
||||
if e == nil && project.Kind == "project" && !project.Archived {
|
||||
if base := s.taskPagePath(r, project.PageUUID); base != "" {
|
||||
sub := project.NotesSubpath
|
||||
if sub == "" {
|
||||
sub = "tasks"
|
||||
}
|
||||
prefix = strings.TrimRight(base, "/") + "/" + sub
|
||||
}
|
||||
}
|
||||
}
|
||||
if prefix == "" {
|
||||
writeEventJSON(w, 422, map[string]string{"error": "wiki_prefix_required"})
|
||||
return
|
||||
}
|
||||
if !store.ValidTaskWikiPrefix(prefix) {
|
||||
taskError(w, store.ErrTaskInvalid)
|
||||
return
|
||||
}
|
||||
target = store.TaskCaptureWikiPath(prefix, item.Title, input.RequestID)
|
||||
for _, capability := range []string{"read", "create", "write"} {
|
||||
if s.authorizePathRequest(r, capability, target) != nil {
|
||||
taskError(w, store.ErrAccessDenied)
|
||||
return
|
||||
}
|
||||
}
|
||||
body = *input.WikiBody
|
||||
} else if input.WikiPrefix != nil {
|
||||
taskError(w, store.ErrTaskInvalid)
|
||||
return
|
||||
}
|
||||
item, err = s.store.CaptureTaskWithWiki(r.Context(), domain, actor, input.RequestID, requestHash, item, target, body)
|
||||
if err != nil {
|
||||
taskError(w, err)
|
||||
return
|
||||
|
||||
Reference in new issue
Block a user