Enable CLI language-aware editing and reuse OIDC authentication
This commit is contained in:
1 parent
5821254535
commit
93f4ecb8f4
11 files changed
+264
-84
No files matched your search
@@ -88,9 +88,9 @@ func TestCLIAuthExchangeIsAtomicAndSingleUse(t *testing.T) {
|
||||
}
|
||||
|
||||
func TestCLIAuthBoundariesAndRevocation(t *testing.T) {
|
||||
for _, mode := range []string{"domain", "origin", "verifier", "device", "expired", "denied", "suspended", "membership", "browser revoked", "new totp"} {
|
||||
for _, mode := range []string{"domain", "origin", "verifier", "device", "expired", "denied", "suspended", "membership", "browser revoked"} {
|
||||
t.Run(mode, func(t *testing.T) {
|
||||
s, principal, browser := cliAuthFixture(t)
|
||||
s, _, browser := cliAuthFixture(t)
|
||||
ctx := context.Background()
|
||||
verifier := strings.Repeat("b", 43)
|
||||
id, device, code, err := s.StartCLIAuth(ctx, "domain", cliTestOrigin, hashAuthToken(verifier))
|
||||
@@ -122,11 +122,6 @@ func TestCLIAuthBoundariesAndRevocation(t *testing.T) {
|
||||
query = `UPDATE domain_memberships SET state='suspended'`
|
||||
case "browser revoked":
|
||||
query = `UPDATE auth_sessions SET revoked_at_ms=1`
|
||||
case "new totp":
|
||||
_, err = s.DB.Exec(`INSERT INTO auth_credentials(uuid,principal_uuid,kind,identifier,secret_hash,created_at_ms,updated_at_ms,enabled) VALUES('totp',?,'totp',?,'invalid',1,1,1)`, principal, principal)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}
|
||||
if query != "" {
|
||||
if _, err := s.DB.Exec(query); err != nil {
|
||||
@@ -202,7 +197,7 @@ func TestCLIAuthSessionFailureRollsBackConsumption(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestCLIAuthRequiresTOTPAndPreservesLevel(t *testing.T) {
|
||||
func TestCLIAuthOIDCDoesNotRepeatLocalTOTPOrInventMFA(t *testing.T) {
|
||||
s, principal, browser := cliAuthFixture(t)
|
||||
ctx := context.Background()
|
||||
verifier := strings.Repeat("t", 43)
|
||||
@@ -232,14 +227,7 @@ func TestCLIAuthRequiresTOTPAndPreservesLevel(t *testing.T) {
|
||||
if err := s.BindCLIAuth(ctx, "domain", cliTestOrigin, id, browser); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if err := s.DecideCLIAuth(ctx, "domain", cliTestOrigin, id, browser, userCode, "", true); err == nil {
|
||||
t.Fatal("TOTP bypass")
|
||||
}
|
||||
code, err = totpCode(secret, time.Now().Unix()/30+1)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if err := s.DecideCLIAuth(ctx, "domain", cliTestOrigin, id, browser, userCode, code, true); err != nil {
|
||||
if err := s.DecideCLIAuth(ctx, "domain", cliTestOrigin, id, browser, userCode, "", true); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
token, _, _, err := s.ExchangeCLIAuth(ctx, "domain", cliTestOrigin, device, verifier)
|
||||
@@ -247,7 +235,29 @@ func TestCLIAuthRequiresTOTPAndPreservesLevel(t *testing.T) {
|
||||
t.Fatal(err)
|
||||
}
|
||||
var level int
|
||||
if err := s.DB.QueryRow(`SELECT mfa_level FROM auth_sessions WHERE token_hash=?`, hashAuthToken(token)).Scan(&level); err != nil || level != 0 {
|
||||
t.Fatalf("OIDC must not invent local MFA: %d %v", level, err)
|
||||
}
|
||||
// Preserve an actually verified level from the bound browser session.
|
||||
strongBrowser, err := s.CreateBrowserAuthSession("domain", principal, 1)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
id, device, userCode, err = s.StartCLIAuth(ctx, "domain", cliTestOrigin, hashAuthToken(verifier))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if err := s.BindCLIAuth(ctx, "domain", cliTestOrigin, id, strongBrowser); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if err := s.DecideCLIAuth(ctx, "domain", cliTestOrigin, id, strongBrowser, userCode, "", true); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
token, _, _, err = s.ExchangeCLIAuth(ctx, "domain", cliTestOrigin, device, verifier)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if err := s.DB.QueryRow(`SELECT mfa_level FROM auth_sessions WHERE token_hash=?`, hashAuthToken(token)).Scan(&level); err != nil || level != 1 {
|
||||
t.Fatalf("MFA not preserved: %d %v", level, err)
|
||||
t.Fatalf("verified MFA level lost: %d %v", level, err)
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user