feat: add audited work records and controlled digest retries
Build and publish container images / images (push) Successful in 12m27s
Build and publish container images / images (push) Successful in 12m27s
This commit is contained in:
1 parent
6e0aecdfb3
commit
e65ca56f92
33 files changed
+2262
-114
No files matched your search
@@ -38,67 +38,110 @@ func sendTaskDigestSMTP(ctx context.Context, config store.AuthProviderConfig, re
|
||||
func (s *Server) deliverTaskDigests(ctx context.Context, job *store.EventJob) error {
|
||||
ctx, cancel := context.WithTimeout(ctx, 30*time.Second)
|
||||
defer cancel()
|
||||
if _, err := s.store.MaintainTaskDigests(ctx, time.Now()); err != nil {
|
||||
return err
|
||||
}
|
||||
queued, err := s.store.QueuedTaskDigests(ctx)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
due, err := s.store.DueTaskDigests(ctx, time.Now())
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
sent, uncertain := 0, 0
|
||||
for _, candidate := range due {
|
||||
sent, uncertain, checked := 0, 0, 0
|
||||
deliver := func(claim store.TaskDigestClaim) error {
|
||||
state, reason := s.deliverTaskDigest(ctx, claim)
|
||||
if state == "sent" {
|
||||
sent++
|
||||
}
|
||||
if state == "uncertain" {
|
||||
uncertain++
|
||||
}
|
||||
checked++
|
||||
finish, stop := context.WithTimeout(context.Background(), 2*time.Second)
|
||||
defer stop()
|
||||
err := s.store.FinishTaskDigestReason(finish, claim, state, reason, time.Now())
|
||||
// A reclaimed generation cannot complete a newer attempt.
|
||||
if errors.Is(err, store.ErrTaskConflict) {
|
||||
return nil
|
||||
}
|
||||
return err
|
||||
}
|
||||
// Alternate automatic delivery and manual retries within the shared time
|
||||
// budget, so a retry backlog cannot monopolize scheduled deliveries.
|
||||
for i := 0; i < max(len(due), len(queued)); i++ {
|
||||
for _, manual := range []bool{false, true} {
|
||||
if ctx.Err() != nil {
|
||||
break
|
||||
}
|
||||
var claim store.TaskDigestClaim
|
||||
var e error
|
||||
if manual {
|
||||
if i >= len(queued) {
|
||||
continue
|
||||
}
|
||||
claim, e = s.store.ClaimQueuedTaskDigest(ctx, queued[i], time.Now())
|
||||
} else {
|
||||
if i >= len(due) {
|
||||
continue
|
||||
}
|
||||
claim, e = s.store.ClaimTaskDigest(ctx, due[i], time.Now())
|
||||
}
|
||||
if errors.Is(e, sql.ErrNoRows) {
|
||||
continue
|
||||
}
|
||||
if e != nil {
|
||||
return e
|
||||
}
|
||||
if e = deliver(claim); e != nil {
|
||||
return e
|
||||
}
|
||||
}
|
||||
if ctx.Err() != nil {
|
||||
break
|
||||
}
|
||||
claim, e := s.store.ClaimTaskDigest(ctx, candidate, time.Now())
|
||||
if errors.Is(e, sql.ErrNoRows) {
|
||||
continue
|
||||
}
|
||||
if e != nil {
|
||||
return e
|
||||
}
|
||||
state := "cancelled"
|
||||
if s.systemExtensionEnabled(claim.Domain, "organizer.tasks") {
|
||||
config, e := s.store.AuthProviderConfig(claim.Domain, "smtp")
|
||||
if e == nil && config.Enabled {
|
||||
items, next, e := s.store.ListTasks(ctx, claim.Domain, claim.Owner, store.TaskQuery{Kind: "task", View: "today", Today: claim.Day, Limit: 100})
|
||||
if e == nil {
|
||||
var body strings.Builder
|
||||
host, _ := s.store.GetDomainEffectiveHost(claim.Domain)
|
||||
base := ""
|
||||
if host != "" && !strings.ContainsAny(host, "/\\\r\n\t @") {
|
||||
base = "https://" + host
|
||||
}
|
||||
fmt.Fprintf(&body, "Tasks / やることリスト — %s (%s)\n\n", claim.Day, claim.Timezone)
|
||||
if len(items) == 0 {
|
||||
body.WriteString("No tasks due or planned today. / 今日の対象タスクはありません。\n")
|
||||
}
|
||||
for _, item := range items {
|
||||
fmt.Fprintf(&body, "- %s\n due/期限: %s | planned/予定: %s | estimate/見積: %d min\n %s/v/plan/task/%s\n", item.Title, item.DueOn, item.PlannedOn, item.Estimate, base, item.UUID)
|
||||
}
|
||||
if next != "" {
|
||||
body.WriteString("\nFirst 100 items only. / 最初の100件です。続きはタスク画面で確認してください。\n")
|
||||
}
|
||||
// Check consent and current account email immediately before send.
|
||||
if recipient, e := s.store.TaskDigestRecipient(ctx, claim); e == nil {
|
||||
state = "uncertain"
|
||||
if e = sendTaskDigestSMTP(ctx, config, recipient, claim.Day, body.String()); e == nil {
|
||||
state = "sent"
|
||||
sent++
|
||||
} else {
|
||||
uncertain++
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
// Persist delivery outcome even if the scheduler context was cancelled.
|
||||
finish, stop := context.WithTimeout(context.Background(), 2*time.Second)
|
||||
e = s.store.FinishTaskDigest(finish, claim, state)
|
||||
stop()
|
||||
if e != nil {
|
||||
return e
|
||||
}
|
||||
}
|
||||
if len(due) > 0 {
|
||||
s.addEventProgressLog(ctx, job, fmt.Sprintf("task digest checked=%d sent=%d uncertain=%d", len(due), sent, uncertain))
|
||||
if checked > 0 {
|
||||
s.addEventProgressLog(ctx, job, fmt.Sprintf("task digest checked=%d sent=%d uncertain=%d", checked, sent, uncertain))
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
func (s *Server) deliverTaskDigest(ctx context.Context, claim store.TaskDigestClaim) (string, string) {
|
||||
if !s.systemExtensionEnabled(claim.Domain, "organizer.tasks") {
|
||||
return "cancelled", "extension_disabled"
|
||||
}
|
||||
config, err := s.store.AuthProviderConfig(claim.Domain, "smtp")
|
||||
if err != nil || !config.Enabled {
|
||||
return "cancelled", "smtp_unavailable"
|
||||
}
|
||||
items, next, err := s.store.ListTasks(ctx, claim.Domain, claim.Owner, store.TaskQuery{Kind: "task", View: "today", Today: claim.Day, Limit: 100})
|
||||
if err != nil {
|
||||
return "cancelled", "tasks_unavailable"
|
||||
}
|
||||
var body strings.Builder
|
||||
host, _ := s.store.GetDomainEffectiveHost(claim.Domain)
|
||||
base := ""
|
||||
if host != "" && !strings.ContainsAny(host, "/\\\r\n\t @") {
|
||||
base = "https://" + host
|
||||
}
|
||||
fmt.Fprintf(&body, "Tasks / やることリスト — %s (%s)\n\n", claim.Day, claim.Timezone)
|
||||
if len(items) == 0 {
|
||||
body.WriteString("No tasks due or planned today. / 今日の対象タスクはありません。\n")
|
||||
}
|
||||
for _, item := range items {
|
||||
fmt.Fprintf(&body, "- %s\n due/期限: %s | planned/予定: %s | estimate/見積: %d min\n %s/v/plan/task/%s\n", item.Title, item.DueOn, item.PlannedOn, item.Estimate, base, item.UUID)
|
||||
}
|
||||
if next != "" {
|
||||
body.WriteString("\nFirst 100 items only. / 最初の100件です。続きはタスク画面で確認してください。\n")
|
||||
}
|
||||
recipient, err := s.store.TaskDigestRecipient(ctx, claim)
|
||||
if err != nil {
|
||||
return "cancelled", "consent_changed"
|
||||
}
|
||||
if err = sendTaskDigestSMTP(ctx, config, recipient, claim.Day, body.String()); err != nil {
|
||||
return "uncertain", "transport_uncertain"
|
||||
}
|
||||
return "sent", ""
|
||||
}
|
||||
Reference in new issue
Block a user