package store import ( "database/sql" "sync" "testing" ) func TestGroupOwnerIntegrity(t *testing.T) { database, err := sql.Open("sqlite", t.TempDir()+"/groups.db?_pragma=busy_timeout(5000)") if err != nil { t.Fatal(err) } defer database.Close() st := &Store{DB: database, authKey: make([]byte, 32)} if err := st.EnsureAuthSchema(); err != nil { t.Fatal(err) } owner, err := st.BootstrapOwner("d", "owner", "correct horse battery staple", "Owner", "") if err != nil { t.Fatal(err) } second, err := st.CreatePasswordAccount("d", "second", "correct horse battery staple", "Second", "") if err != nil { t.Fatal(err) } group, err := st.CreateGroup("d", owner.UUID, "team", "Team", "", "members") if err != nil { t.Fatal(err) } for _, role := range []string{"member", "manager"} { if err := st.AddGroupMemberByUsername("d", group.UUID, "owner", role); err == nil { t.Fatalf("owner downgraded to %s", role) } } if err := st.AddGroupMemberByUsername("other", group.UUID, "owner", "owner"); err == nil { t.Fatal("cross-domain member accepted") } var firstID, secondID string if err := database.QueryRow(`SELECT uuid FROM domain_memberships WHERE domain_uuid='d' AND principal_uuid=?`, owner.UUID).Scan(&firstID); err != nil { t.Fatal(err) } if err := database.QueryRow(`SELECT uuid FROM domain_memberships WHERE domain_uuid='d' AND principal_uuid=?`, second.UUID).Scan(&secondID); err != nil { t.Fatal(err) } if err := st.RemoveGroupMember(group.UUID, firstID); err == nil { t.Fatal("last owner removed") } if err := st.AddGroupMemberByUsername("d", group.UUID, "second", "owner"); err != nil { t.Fatal(err) } if err := st.RemoveGroupMemberWithAuthority(group.UUID, secondID, false); err == nil { t.Fatal("manager removed an owner") } // Two concurrent removals must not both pass a previously read owner count. var wg sync.WaitGroup start := make(chan struct{}) results := make(chan error, 2) for _, id := range []string{firstID, secondID} { wg.Add(1) go func(id string) { defer wg.Done(); <-start; results <- st.RemoveGroupMember(group.UUID, id) }(id) } close(start) wg.Wait() close(results) success := 0 for err := range results { if err == nil { success++ } } var owners int if err := database.QueryRow(`SELECT COUNT(*) FROM group_members WHERE group_uuid=? AND member_role='owner'`, group.UUID).Scan(&owners); err != nil { t.Fatal(err) } if success != 1 || owners != 1 { t.Fatalf("concurrent removal: succeeded=%d owners=%d", success, owners) } }