package store import ( "context" "database/sql" "errors" "fmt" "strings" "testing" "time" "pageswiki/internal/db" ) func cityReadFixture(t *testing.T) *Store { t.Helper() database, err := db.Open(t.TempDir() + "/city.db") if err != nil { t.Fatal(err) } t.Cleanup(func() { _ = database.Close() }) st := &Store{DB: database} if err := st.EnsureCitySchema(); err != nil { t.Fatal(err) } if _, err := database.Exec(`CREATE TABLE paths(domain_uuid TEXT,path TEXT,object_uuid TEXT,is_primary INTEGER DEFAULT 0,PRIMARY KEY(domain_uuid,path)); CREATE INDEX city_test_path_object ON paths(domain_uuid,object_uuid)`); err != nil { t.Fatal(err) } return st } func cityReadTopology(t *testing.T, st *Store, domain, path string) (string, string, string) { t.Helper() q, err := st.CreateZoneAtPath(domain, "actor", "quartier", "", "quarter", "Quarter", "", path) if err != nil { t.Fatal(err) } base := strings.TrimRight(normalizePath(path), "/") street, err := st.CreateZoneAtPath(domain, "actor", "street", q, "street", "Street", "", base+"/home") if err != nil { t.Fatal(err) } spot, err := st.CreateSpotAtPath(domain, "actor", street, "spot", "Spot", "", base+"/home/kitchen") if err != nil { t.Fatal(err) } return q, street, spot } func cityTestExec(t *testing.T, st *Store, query string, args ...any) { t.Helper() if _, err := st.DB.Exec(query, args...); err != nil { t.Fatal(err) } } func assertCityReadConnectionReturned(t *testing.T, st *Store) { t.Helper() // database/sql may finish its cancellation-triggered rollback on another // goroutine after a caller observes the deadline. Reacquiring the only // connection tests the actual leak contract without a racy Stats snapshot. ctx, cancel := context.WithTimeout(context.Background(), time.Second) defer cancel() conn, err := st.DB.Conn(ctx) if err != nil { t.Fatalf("City read leaked its sole connection: %v", err) } _ = conn.Close() } func TestCityReadSingleConnectionAndSnapshot(t *testing.T) { st := cityReadFixture(t) q, street, spot := cityReadTopology(t, st, "d", "/life") cityTestExec(t, st, `INSERT INTO paths VALUES('d','/life/home/kitchen','portal',1),('d','/life/home/kitchen/page','page',1)`) if err := st.AddSpotPage("d", "actor", spot, "portal", "", "primary", "Portal"); err != nil { t.Fatal(err) } if err := st.AddSpotPage("d", "actor", spot, "portal", "", "reference", "Reference"); err != nil { t.Fatal(err) } st.DB.SetMaxOpenConns(1) ctx, cancel := context.WithTimeout(context.Background(), time.Second) defer cancel() city, err := st.GetCityMapContext(ctx, "d") if err != nil { t.Fatalf("single connection read failed: %v", err) } got := city.Quartiers[0].Streets[0].Spots[0] if got.UUID != spot || got.PageCount != 2 || len(got.Pages) != 3 || got.PortalPath != "/life/home/kitchen" { t.Fatalf("deduplicated snapshot = %#v", got) } assertCityReadConnectionReturned(t, st) st.DB.SetMaxOpenConns(2) tx, err := st.DB.BeginTx(ctx, &sql.TxOptions{ReadOnly: true}) if err != nil { t.Fatal(err) } defer tx.Rollback() var before int64 if err := tx.QueryRow(`SELECT version FROM domain_topology_versions WHERE domain_uuid='d'`).Scan(&before); err != nil { t.Fatal(err) } // Commit after the reader pins the snapshot, before topology/Page loading. writer, err := st.DB.Begin() if err != nil { t.Fatal(err) } if _, err = writer.Exec(`UPDATE zones SET title='New title' WHERE uuid IN (?,?); UPDATE paths SET path='/changed' WHERE object_uuid='page'; UPDATE domain_topology_versions SET version=version+1 WHERE domain_uuid='d'`, q, street); err != nil { _ = writer.Rollback() t.Fatal(err) } if err := writer.Commit(); err != nil { t.Fatal(err) } old, err := readCityMapTx(cityReadQuery{ctx: ctx, tx: tx}, "d") if err != nil || old.Version != before || old.Quartiers[0].Title != "Quarter" || old.Quartiers[0].Streets[0].Spots[0].PageCount != 2 { t.Fatalf("mixed concurrent snapshot: %#v, %v", old, err) } _ = tx.Rollback() current, err := st.GetCityMap("d") if err != nil || current.Version != before+1 || current.Quartiers[0].Title != "New title" || current.Quartiers[0].Streets[0].Spots[0].PageCount != 1 { t.Fatalf("new snapshot missing commit: %#v, %v", current, err) } } func TestCityReadRejectsBudgetAndReleasesConnection(t *testing.T) { for _, budget := range []string{"nodes", "pages", "relations"} { t.Run(budget, func(t *testing.T) { st := cityReadFixture(t) _, street, spot := cityReadTopology(t, st, "d", "/life") switch budget { case "nodes": cityTestExec(t, st, `WITH RECURSIVE n(i) AS (SELECT 1 UNION ALL SELECT i+1 FROM n WHERE i