Files
pages/internal/server/event_log_reporting_test.go
Anya Tokugawa a36934e72c
Build and publish container images / images (push) Successful in 16m17s
Release container images / release (push) Successful in 39s
Fix event log writer contention and report persistence failures safely
Take the SQLite writer lock before reading job/policy facts, bound acquisition and cancellation, preserve atomic raw logs and counters, and avoid replaying successful business operations on logging failure. Tested the isolated nine-file release slice with the full Go suite, race tests and go vet.
2026-11-01 19:40:26 +09:00

67 lines
2.1 KiB
Go

package server
import (
"bytes"
"context"
"log"
"strings"
"testing"
"time"
"pageswiki/internal/db"
"pageswiki/internal/dregarnuhr"
"pageswiki/internal/store"
)
func TestEventLoggingFailureReportedWithoutReexecuting(t *testing.T) {
database, err := db.Open(t.TempDir() + "/queue.db")
if err != nil {
t.Fatal(err)
}
defer database.Close()
st := &store.Store{DB: database}
if err := st.EnsureEventJobsSchema(); err != nil {
t.Fatal(err)
}
// A malicious/verbose driver message must never be copied to compose logs.
if _, err := database.Exec(`CREATE TRIGGER fail_log BEFORE INSERT ON event_logs BEGIN SELECT RAISE(ABORT,'secret-payload-123'); END`); err != nil {
t.Fatal(err)
}
var output bytes.Buffer
old := log.Writer()
log.SetOutput(&output)
defer log.SetOutput(old)
s := &Server{store: st, schedulerWake: make(chan struct{}, 8)}
if err := s.registeredEventHandlers().Register("test.log-failure", func(ctx context.Context, job *dregarnuhr.Job) error {
s.addEventProgressLog(ctx, job, "private-progress-456")
return nil
}); err != nil {
t.Fatal(err)
}
_, err = st.EnqueueEvent("test.log-failure", "key", "secret-body-789", time.Now().Add(-time.Second))
if err != nil {
t.Fatal(err)
}
s.eventRunner().Dispatch(context.Background())
select {
case <-s.schedulerWake:
case <-time.After(5 * time.Second):
t.Fatal("worker did not complete")
}
var status string
var attempts int
if err := database.QueryRow(`SELECT status,attempts FROM event_jobs WHERE event_type='test.log-failure'`).Scan(&status, &attempts); err != nil || status != "succeeded" || attempts != 1 {
t.Fatalf("log failure retried business operation: %s %d %v", status, attempts, err)
}
for _, stage := range []string{"start-log", "progress-log", "finish-log"} {
if !strings.Contains(output.String(), stage+" failed") {
t.Fatalf("missing %s diagnostic: %s", stage, output.String())
}
}
for _, secret := range []string{"secret-payload-123", "private-progress-456", "secret-body-789"} {
if strings.Contains(output.String(), secret) {
t.Fatal("diagnostic leaked content")
}
}
}